OCM-10315 : Add instance addition script #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/ocm-support/root.go
Outdated
| @@ -17,6 +17,7 @@ limitations under the License. | |||
| package main | |||
|
|
|||
| import ( | |||
| "github.com/openshift-online/ocm-support-cli/cmd/ocm-support/add" | |||
There was a problem hiding this comment.
nit: order of imports
|
@tirthct can you add an example in the README about how to use this? |
As discussed, we will create a new PR for documentation once the script it ready |
|
|
||
| func init() { | ||
| flags := Cmd.Flags() | ||
| flags.BoolVar(&args.dryRun, "dry-run", true, "When true, don't actually take any actions, just print the actions that would be taken") |
There was a problem hiding this comment.
This message is quite generic, can we improve that/make more clear?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed